CLI-1227: Implement PHP 8 attributes #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
============================================
- Coverage 91.96% 91.80% -0.17%
+ Complexity 1820 1776 -44
============================================
Files 124 122 -2
Lines 6513 6381 -132
============================================
- Hits 5990 5858 -132
Misses 523 523 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to more radically strip
configure()into attributes, but it turns out Symfony doesn't support that natively. The goal of AsCommand is only to replace static properties like the name and description, not all of the possible methods inconfigure().Drush accomplishes this using consolidation annotated commands. It's a work of art, but I'd rather stick with pure Symfony patterns for now.